Fix: Autoload CryptoProvider classes #406
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
(fixes a bug where scrypt/bcrypt gems are required to run Authlogic -- let's just require them when necessary)
| rw_config(:crypto_provider, CryptoProviders::SCrypt) | ||
| else | ||
| rw_config(:crypto_provider, value) | ||
| end |
There was a problem hiding this comment.
This is the only semi-weird part. Loading SCrypt here would require the gem (even w/autoload). So I only set it as the default if the provider hasn't been set yet.
It works, but another alternative could be allowing procs as the rw_config value?
tiegz
changed the title
|
+1 for this |
|
+1, also addresses my issue #405. |
|
+1 |
1 similar comment
|
+1 |
binarylogic
added a commit
that referenced
this pull request
Apr 28, 2014
Fix: Autoload CryptoProvider classes
|
thx! @yourewelcome you weren't out at RailsConf, were you? |
|
No, I wanted to go, couldn't make it this year. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In a recent commit (c2eae1c) I removed some old require code for bcrypt/scrypt.
This ends up throwing the
LoadErrorin your app if you don't have those two gems in your Gemfile, but we still don't necessarily need the gems to run Authlogic.This change autoloads each
CryptoProviderwhen necessary rather than requiring all of them when loading Authlogic.